Skip to content

<chrono> formatting: Simplify test #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 4 commits into from
Apr 19, 2021
Merged

<chrono> formatting: Simplify test #1859

StephanTLavavej merged 4 commits into from
Apr 19, 2021

Conversation

@StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Apr 19, 2021

  • Replace stream_helper with empty_braces_helper.
  • Replace assert(format(STR("{}"), A) == B) with empty_braces_helper(A, B).
  • Remove resulting duplicate lines.
  • Simplify choose_literal.
  • Use STR consistently.

@StephanTLavavej StephanTLavavej added test Related to test code chrono C++20 chrono labels Apr 19, 2021
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 19, 2021 04:36
@StephanTLavavej StephanTLavavej merged commit c06416c into microsoft:chronat2 Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chrono C++20 chrono test Related to test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@StephanTLavavej