chronat: Add duration formatter #1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special specifiers for duration are `j q Q`. Otherwise duration is very similar to `hh_mm_ss` except that times are interpreted as time from midnight. I thought this would mean that negative times are yesterday, but we just append a `-` instead, which means we should round instead of flooring to a day when computing hh/mm/ss. Other behavior is pretty simple.
StephanTLavavej
requested changes
Apr 19, 2021
StephanTLavavej
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special specifiers for duration are
j q Q.Otherwise duration is very similar to
hh_mm_ssexcept that times areinterpreted as time from midnight. I thought this would mean that
negative times are yesterday, but we just append a
-instead, whichmeans we should round towards zero (i.e. truncate or
duration_cast)instead of flooring to a day when computing hh/mm/ss.
Other behavior is pretty simple.