P1518R2 Stop Overconstraining Allocators In Container Deduction Guides #2032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
changed the title
miscco
reviewed
Jul 1, 2021
tests/std/tests/P1518R2_stop_overconstraining_allocators/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
requested changes
Aug 20, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks for implementing this CTAD paper!
tests/std/tests/P1518R2_stop_overconstraining_allocators/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P1518R2_stop_overconstraining_allocators/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/P1518R2_stop_overconstraining_allocators/test.compile.pass.cpp
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Aug 20, 2021
StephanTLavavej
assigned
CaseyCarter and
StephanTLavavej and unassigned
StephanTLavavej
Member
|
I'm mirroring this to an MSVC-internal PR. Changes can still be pushed during final review, but please notify me if that happens. |
Member
|
Had to push a change to get this to pass in the internal test harness, which always wants to link and run tests (even if they're named |
CaseyCarter
approved these changes
Aug 26, 2021
Member
|
Thanks for improving CTAD, one of my favorite features! 😻 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1974
https://wg21.link/P1518R2
I have a few questions:
It works with
clang-cland doesn't work withcl. Is it me or the compiler has a bug?libc++ did it in C++17: llvm/llvm-project@dd15c27
Is it ok do same for compatibility with libc ++ tests?