Skip to content

Alternative way to optimize _Countr_zero #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 14 commits into from
Jan 22, 2022
Merged

Alternative way to optimize _Countr_zero #2343

StephanTLavavej merged 14 commits into from
Jan 22, 2022

Conversation

@AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Nov 18, 2021

Do stuff like _Select_popcount_impl.

Resolves #2292 a bit more efficient than #2298

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner November 18, 2021 10:35
@AlexGuteniev AlexGuteniev mentioned this pull request Nov 18, 2021
Closed
@StephanTLavavej StephanTLavavej added the performance Must go faster label Nov 19, 2021
StephanTLavavej
StephanTLavavej reviewed Nov 23, 2021
View reviewed changes
@StephanTLavavej StephanTLavavej self-assigned this Dec 18, 2021
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej removed their assignment Dec 18, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 20, 2022

I've pushed a merge with main to resolve a simple conflict in <numeric> (where clang-format 13 had removed a space). I diffed <numeric> before and after this merge, and there are no changes to this PR's content except for the clang-format changes.

@StephanTLavavej StephanTLavavej self-assigned this Jan 21, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 21, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 51ad398 into microsoft:main Jan 22, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jan 22, 2022

Thanks for improving the performance of this function with clear, maintainable code! 🚀 🎉 😻

@AlexGuteniev AlexGuteniev deleted the lcm branch January 22, 2022 04:21
@MattStephanson MattStephanson mentioned this pull request Jan 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

performance Must go faster

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<numeric>: _Countr_zero used by std::gcd has unnecessary zero checks

4 participants

@AlexGuteniev @StephanTLavavej @CaseyCarter @barcharcraz