Render keys_view and values_view useless per LWG-3563 #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(There's an argument to be made that they were useless before when they named the result type of `views::keys(declval<Rng>())` and `views::values(declval<Rng>())`, but they certainly are now.) Change our test coverage to `views::keys` and `views::values`, the intended UX for extracting fields from ranges. Fixes microsoft#2389
miscco
approved these changes
Dec 17, 2021
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Thanks for submitting this totally unbiased first issue
StephanTLavavej
approved these changes
Dec 18, 2021
mnatsuhara
approved these changes
Jan 13, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this LWG issue! 😹 🎉 ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(There's an argument to be made that they were useless before when they named the result type of
views::keys(declval<Rng>())andviews::values(declval<Rng>()), but they certainly are now.) Change our test coverage toviews::keysandviews::values, the intended UX for extracting fields from ranges.Fixes #2389