<ciso646> is removed in C++20
#2710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
May 11, 2022
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
I suspect there is code in the wild building with /std:c++20 /permissive that includes <ciso646> to get the macro definitions of the "alternative tokens" (and, not, etc.) which will be broken by this, but I'm comfortable given there's an escape hatch.
tests/std/tests/VSO_0000000_instantiate_iterators_misc/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
approved these changes
May 11, 2022
StephanTLavavej
approved these changes
May 12, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 16, 2022
Member
|
Merged with
|
Member
|
Thanks for implementing this removal and helping to modernize this part of the ecosystem! 😻 🚀 🧑🚀 |
fsb4000
added a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.cppreference.com/w/cpp/header
<ciso646>wasn't deprecated in C++17, this is why<ciso646>doesn't have a similar warning like<cstdbool>and other have.#2583 uses
STL4034andSTL4035so this PR is expected to be merged after 2583
llvm-project\libcxx\test\support\test_macros.h has
#include <ciso646>. This is why we need#define _SILENCE_CXX20_CISO646_REMOVED_WARNINGforP0088R3_variant/test.cpp,P0220R1_any/test.cppandP0220R1_optional/test.cpphttps://github.com/llvm/llvm-project/blob/b8d38e8b4fcab071c5c4cb698e154023d06de69e/libcxx/test/support/test_macros.h#L23