[vector.bool] Optimize copy / move algorithms #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
requested changes
Jan 20, 2023
This comment was marked as resolved.
This comment was marked as resolved.
miscco
force-pushed
the
vector_bool_copy
branch
from
f28e518
to
c849d8a
Compare
miscco
force-pushed
the
vector_bool_copy
branch
from
c849d8a
to
f413538
Compare
benchmarks/src/std/containers/sequences/vector.bool/move/test.cpp
Outdated
Show resolved
Hide resolved
barcharcraz
suggested changes
Feb 24, 2023
benchmarks/src/std/containers/sequences/vector.bool/move/test.cpp
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
benchmarks/src/std/containers/sequences/vector.bool/copy/test.cpp
Outdated
Show resolved
Hide resolved
benchmarks/src/std/containers/sequences/vector.bool/copy/test.cpp
Outdated
Show resolved
Hide resolved
benchmarks/src/std/containers/sequences/vector.bool/copy/test.cpp
Outdated
Show resolved
Hide resolved
benchmarks/src/std/containers/sequences/vector.bool/copy/test.cpp
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Sep 12, 2023
|
This has passed a billion iterations ( |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
barcharcraz
approved these changes
Sep 20, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for contributing this major optimization, enduring the almost 2 years it took to review (since the creation of #2461), and finding the time to fix the correctness issues! 👻 🚀 🎉 |
|
I reran the perf numbers and described the speedups in the changelog as varying from 1.8x to 3200x (of course this was only on my machine but the perf numbers are approximate anyways). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of my old PR that optimized the copy / move algorithms
Unfortunately I did not have that much time recently, so here it is finally. The speedup is rather nice and grows well with the size of the array
Results_vec_bool.xlsx