-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hh_mm_ss
formatting for values >= 1 day
#3727
Fix hh_mm_ss
formatting for values >= 1 day
#3727
Conversation
tests/std/tests/GH_003676_format_large_hh_mm_ss_values/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_003676_format_large_hh_mm_ss_values/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_003676_format_large_hh_mm_ss_values/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_003676_format_large_hh_mm_ss_values/test.cpp
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Thanks! I've pushed changes to fix |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for fixing this runtime correctness bug - oh happy day! 😹 📅 🎉 |
Summary of changes:
hh_mm_ss
s >= 1 dayhh_mm_ss
' formatting implementation to use the hours and minutes explicitly (put_time
does not deal with hours >= 24, which is desired behavior)_Hh_mm_ss_part_underflow_to_zero
and instead cast everyduration
to be formatted this way tohh_mm_ss
directly (this is theformat("{:%T}", some_duration) == "00:00:00"
bug discussed in the original issue (not the same bug, but closely related ;))abs
forduration
s slightly.%H
format override.Fixes #3676