Enhance _STL_VERIFY for std::barrier
#3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Jun 10, 2023
achabense
commented
Jun 13, 2023
| @@ -93,9 +93,8 @@ public: | |||
| } | |||
|
|
|||
| _NODISCARD_BARRIER_TOKEN arrival_token arrive(ptrdiff_t _Update = 1) noexcept /* strengthened */ { | |||
| // Shifting before precondition check, so that exceeding max() will trigger precondition check too | |||
| _STL_VERIFY(_Update > 0 && _Update <= (max) (), "Precondition: update > 0 (N4950 [thread.barrier.class]/12)"); | |||
There was a problem hiding this comment.
Sorry for this late review -- I didn't realize it was "Pending"-ed.
_Update <= max() is necessary, as it avoids large positive value becoming negative after shift. However, this will cause a mismatch between the check and error message. This check is more relevant to the constraint "update <= expected count", but I don't think we should put it off. I have no idea how to make an improvement. Any ideas?
There was a problem hiding this comment.
I'm okay with a slightly confusing message here.
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
strega-nil-ms
approved these changes
Jun 14, 2023
|
Thanks for enhancing the Great Galactic Barrier that keeps the Alpha Quadrant safe! 🛡️ 🛸 😹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3748.