<functional>: Deleted operator() overloads for return types of bind, bind_front, and bind_back
#3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately we can't directly use the original file.
My mother was an English teacher so I feel compelled to explain 😸 - "seemingly" is the word to use here (like "apparently"). "seemly" is a completely different word (and is rarely used; usually only the antonym "unseemly" is used). 📚 |
tests/std/tests/GH_000952_bind_constraints/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_000952_bind_constraints/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_000952_bind_constraints/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jul 8, 2023
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Jul 13, 2023
|
Thanks for improving this very tricky metaprogramming! 🛠️ ⚙️ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deleted overloads prevent overload resolution flowing into another unintended overload when the invocation should be (SFINAE-friendlily) ill-formed.
Since the
operator()overloads are constrained in default template arguments now, I think it would be better to usedecltype(auto)to specify the return types.There seems to be something wrong with modules when using traditional SFINAE, so I'm changing to use
requireswhen possible.Unblock one libc++ test:std/utilities/function.objects/func.bind_front/bind_front.pass.cppThe test seemly requires
bind_frontto be SFINAE-friendly, while the Standard uses "Mandates:"... As a result, I decided to copy some parts of that file into MSVC STL's test file.Driven-by:
_STD-qualify the internal calling helpers.