Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include <limits> in <xutility> #3777

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Don't include <limits> in <xutility> #3777

merged 2 commits into from
Jun 22, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Towards #3599.

#832 doesn't seem completely fixed now due to #3678. This PR tries to remove inclusion of <limits> in <xutility>.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner June 17, 2023 12:52
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Jun 17, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jun 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ac138a5 into microsoft:main Jun 22, 2023
@StephanTLavavej
Copy link
Member

Thanks for continuing to explore throughput improvements! 🚀 🐇 🐆

@frederick-vs-ja frederick-vs-ja deleted the throughput-xutility-limits branch June 23, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederick-vs-ja @StephanTLavavej @strega-nil-ms