Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Fix for #3780 #3784

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Documentation Fix for #3780 #3784

merged 1 commit into from
Jun 22, 2023

Conversation

JacobOgle
Copy link
Contributor

@JacobOgle JacobOgle commented Jun 19, 2023 •
edited
Loading

Fix #3780

@JacobOgle
cleanup for #3780
53b8e48 
fix documentation
@JacobOgle JacobOgle requested a review from a team as a code owner June 19, 2023 01:51
@JacobOgle JacobOgle changed the title cleanup for #3780 fix for #3780 Jun 19, 2023
frederick-vs-ja
frederick-vs-ja suggested changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
However, it would be better to write Fix #3780 in the description of this PR, which will automatically tell Github that this PR will resolve the mentioned issue.

@JacobOgle
Copy link
Contributor Author

@frederick-vs-ja apologies for the error! I just fixed the description to match the request. Let me know if anything else is needed!

@JacobOgle JacobOgle changed the title fix for #3780 Documentation Fix for #3780 Jun 19, 2023
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Jun 19, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jun 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9e07371 into microsoft:main Jun 22, 2023
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks for updating this comment - and congratulations on your first microsoft/STL commit! 🎉 😻 🚀

This change will ship in VS 2022 17.8 Preview 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@frederick-vs-ja frederick-vs-ja frederick-vs-ja approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
documentation Related to documentation or comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up comments for LWG-3912 enumerate_view::iterator::operator- should be noexcept
4 participants
@JacobOgle @StephanTLavavej @frederick-vs-ja @strega-nil-ms