Implement P2538R1 ADL-Proof projected
#3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driven by: test `P2609R3_relaxing_ranges_just_a_smidge` in C++20 mode.
frederick-vs-ja
commented
Jul 2, 2023
StephanTLavavej
approved these changes
Jul 4, 2023
|
Thanks, looks perfect! ✨ 🎉 |
strega-nil-ms
approved these changes
Jul 6, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
… struct 'Incomplete'" despite std::variant's ADL defenses
|
I've had to push an additional commit to work around VSO-1659496 " FYI @strega-nil-ms as you previously approved. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks for implementing this feature backwards in time! ⏳ ✅ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As if it is a Defect Report against C++20. Fixes #3801.
Notes: the base class which conditionally provides
difference_typealso seemly needs to be ADL-proof.Unfortunately, the changes are not so awesome at this moment, because MSVC STL hasn't avoided extraneous ADL in most standard algorithms (#140, #1596).
Driven-by: test
P2609R3_relaxing_ranges_just_a_smidgein C++20 mode.