Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage and precondition checking for LWG-2295 Locale name when the provided Facet is a nullptr #3823

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Test coverage and precondition checking for LWG-2295 Locale name when the provided Facet is a nullptr #3823

merged 3 commits into from
Jul 14, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jun 23, 2023 •
edited
Loading

I think that LWG issue is actually already implemented, and thus just add test coverage and precondition checking.

Driven-by change: mark the noexcept checking (added in #3250) as // strengthened.

Fixes #3463.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner June 23, 2023 05:48
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Jun 23, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jun 23, 2023
@StephanTLavavej
Copy link
Member

Thanks, this looks great! 😸 🚀

@StephanTLavavej StephanTLavavej removed their assignment Jul 3, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 13, 2023
@StephanTLavavej
Copy link
Member

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've had to push an additional commit to avoid /clr:pure linker errors in the newly added test code. (/clr:pure is in extreme maintenance mode, so because this isn't a product code regression, we don't need to investigate why this test code doesn't link.)

FYI @CaseyCarter as you might not have seen this latest commit.

@StephanTLavavej StephanTLavavej merged commit 2b8a19b into microsoft:main Jul 14, 2023
35 checks passed
@frederick-vs-ja frederick-vs-ja deleted the lwg-2295 branch July 14, 2023 02:31
@StephanTLavavej
Copy link
Member

Thanks for getting the backlog of LWG issues to be nearly empty! 🎉 😻 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-2295 Locale name when the provided Facet is a nullptr
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter