Initialize array<T, 0>'s single element #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... which shouldn't even be there, but can't be removed because ABI. Fixes DevCom-10299275 / VSO-1759562 / AB#1759562.
StephanTLavavej
approved these changes
Jul 12, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this notoriously annoying bug! 🐞 🛠️ ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which shouldn't even be there, but can't be removed because ABI.
Fixes DevCom-10299275 / VSO-1759562 / AB#1759562.
Notably this will fail with
T's that cannot be{}-initialized, e.g., types with explicit default constructors. We could work around that in C++17-and-later by initializing the array with{T()}, but I didn't want to obfuscate the code and I feel these two corner cases are incredibly unlikely to occur together.