Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect allocate_at_least with a concept #3891

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Detect allocate_at_least with a concept #3891

merged 2 commits into from
Jul 20, 2023

Conversation

CaseyCarter
Copy link
Member

@CaseyCarter CaseyCarter commented Jul 19, 2023 •
edited
Loading

... to avoid DevCom-10419218, a C1XX bug in the non-requires-expression detection.

Fixes VSO-1852860 / AB#1852860

@CaseyCarter
Detect allocate_at_least with a concept
d96fac1 
... to avoid a C1XX bug in the non-requires-expression detection.

Fixes VSO-1852860.
@CaseyCarter CaseyCarter added the bug Something isn't working label Jul 19, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 19, 2023 20:39
@CaseyCarter CaseyCarter linked an issue Jul 19, 2023 that may be closed by this pull request
<xmemory>: allocate_at_least optimization broken by private inheritance from std::allocator #3890
Closed
StephanTLavavej
StephanTLavavej reviewed Jul 19, 2023
View reviewed changes
stl/inc/xmemory Outdated Show resolved Hide resolved
tests/std/tests/GH_003570_allocate_at_least/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter added the high priority Important! label Jul 19, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jul 20, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit b81f61c into microsoft:main Jul 20, 2023
@StephanTLavavej
Copy link
Member

Thanks for working around this compiler bug so elegantly! 🎉 🛠️ ✨

@CaseyCarter CaseyCarter deleted the re_re_un_allocate_at_most branch July 20, 2023 23:54
@CaseyCarter
Copy link
Member Author

I'm sure the millions of users out there with customer allocators that implement allocate_at_least will appreciate all the work we've put into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working high priority Important!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<xmemory>: allocate_at_least optimization broken by private inheritance from std::allocator
2 participants
@CaseyCarter @StephanTLavavej