-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implementation of <flat_map> #3896
[WIP] Implementation of <flat_map> #3896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After all, clang-format needs to run for <flat_map>
after changes.
stl/inc/flat_map
Outdated
struct sorted_unique_t { explicit sorted_unique_t() = default; }; | ||
inline constexpr sorted_unique_t sorted_unique {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These things should be in <xmemory>
. Actually, they are already provided there in the feature/flat_set branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to remove this once the changes of flat_set
are visible on master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usual header stuff
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
5bb5050
to
1f444af
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: A. Jiang <de34@live.cn>
4d6de36
to
aabc8ca
Compare
…&' (the latter requires a transparent comparator)
I've changed the "base" branch so this targets the new I haven't otherwise reviewed the code, but this will be ready to merge as a starting point once the checks are green. Thanks again for all your hard work getting the feature this far! 😻 |
Ongoing work -- implementation of #2910 .
Progress so far:
begin
,end
etc.)