Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_assignable test coverage #3898

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Fix is_assignable test coverage #3898

merged 2 commits into from
Jul 26, 2023

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jul 22, 2023 •
edited
Loading

  • Use lvalue references for the LHS of is_assignable_v and is_nothrow_assignable_v for variant and atomic<shared_ptr>.
    • We expect lvalues even though it technically works with rvalues.
  • Check const rvalues and const lvalues in P2321R2_proxy_reference.
    • This is a "nice to have" expansion of test coverage, as both work, and this makes it clear that we didn't test them unintentionally.
  • Cite LWG-3661 with the usual syntax.

@StephanTLavavej StephanTLavavej added the test Related to test code label Jul 22, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner July 22, 2023 00:08
@StephanTLavavej StephanTLavavej self-assigned this Jul 25, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit cd05c72 into microsoft:main Jul 26, 2023
37 checks passed
@StephanTLavavej StephanTLavavej deleted the is-assignable branch July 26, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephanTLavavej @strega-nil-ms