Implement debug-enabled formatter specializations
#3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This PR implements debug-enabled standard `formatter` specializations, * Drive-by: rename tests added in microsoft#3656 - use `text_formatting_` prefix instead of `formatting_ranges_` (for consistency), * Towards microsoft#2919.
cpplearner
reviewed
Jul 31, 2023
tests/std/tests/P2286R8_text_formatting_debug_enabled_specializations/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_debug_enabled_specializations/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Aug 3, 2023
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Aug 3, 2023
StephanTLavavej
approved these changes
Aug 11, 2023
This comment was marked as resolved.
This comment was marked as resolved.
barcharcraz
approved these changes
Sep 20, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing part of this C++23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatterspecializations,yvals_core.h- I think those changes should have been a part of Implement the?format specifier for strings and characters #3656 and current comment is enough.?format specifier for strings and characters #3656 - usetext_formatting_prefix instead offormatting_ranges_(for consistency) and longer names,