Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused functions from winapisupp.cpp #3936

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Remove unused functions from winapisupp.cpp #3936

merged 2 commits into from
Aug 11, 2023

Conversation

AlexGuteniev
Copy link
Contributor

Resolve #3926

Mostly a red change

Also repeat _CRTIMP2 on __crtGetSystemTimePreciseAsFileTime -- see #3927

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 8, 2023 12:44
@AlexGuteniev AlexGuteniev mentioned this pull request Aug 8, 2023
Closed
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Aug 8, 2023
CaseyCarter
CaseyCarter approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solid cleanup. I git grepped for all the affected names in the MSVC-internal repo - out of an overabundance of paranoia - and found no other occurrences of the removed names.

@StephanTLavavej
Copy link
Member

This is great! 😻

@StephanTLavavej StephanTLavavej self-assigned this Aug 10, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej mentioned this pull request Aug 10, 2023
Closed
@StephanTLavavej
Copy link
Member

I've pushed a merge with main to resolve a conflict in stl/src/winapisupp.cpp where #3900 updated preprocessor comments. Resolved by accepting this PR's code elimination; with only #if and #endif we don't need arrow comments.

@StephanTLavavej StephanTLavavej merged commit c623688 into microsoft:main Aug 11, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for noticing and eliminating all of this dead code! 🧟 ☠️ 😻

@AlexGuteniev AlexGuteniev deleted the wassup branch August 11, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why are these functions preserved?
3 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter