Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.8 Preview 1 #3939

Merged
merged 6 commits into from
Aug 10, 2023

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Aug 8, 2023

This updates the pool for VS 2022 17.8 Preview 1, including August's Patch Tuesday.

We're not yet able to require 17.8 because the internal build is still starting with 17.6 (!). No changes to CMake/Ninja/Clang versions.

Update to PowerShell 7.3.6 when building the pool.

We're able to remove a couple of compiler bug workarounds:

  • Remove workaround for VSO-1659408 "/clr alignas emits error C2711 "this function cannot be compiled as managed" instead of falling back to native codegen"
    • Validated internally.
    • One workaround had to be retained due to an apparently different bug that has now been revealed. I filed VSO-1867037 "/clr C++20 System.AccessViolationException with ranges uninitialized algorithms".
    • Two more workarounds had to be retained due to VSO-1659695 "/clr x86 runtime assertions/crashes with parallel algorithms".
  • Remove workaround for VSO-1849458 "REPORTED: EDG mishandles is_layout_compatible_v<const int[], int[]>"

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Aug 8, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 8, 2023 20:54
@StephanTLavavej StephanTLavavej self-assigned this Aug 10, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member Author

@CaseyCarter I had to push an additional commit after you approved, to restore a couple of /clr workarounds and update their citations. (I had validated x64 but these are specific to x86.)

@StephanTLavavej StephanTLavavej merged commit a669eae into microsoft:main Aug 10, 2023
35 checks passed
@StephanTLavavej StephanTLavavej deleted the vs17.8p1 branch August 10, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants