Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2675R1 <format> generator converted from C++ to Python #3994

Merged
merged 24 commits into from
Oct 6, 2023
Merged

P2675R1 <format> generator converted from C++ to Python #3994

merged 24 commits into from
Oct 6, 2023

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Aug 26, 2023

Fixes #3908

@fsb4000 fsb4000 requested a review from a team as a code owner August 26, 2023 14:16
@achabense

This comment was marked as resolved.

Sign in to view
fsb4000 and others added 3 commits August 26, 2023 22:16
@fsb4000 @achabense
change a comment
2ba4369 
Co-authored-by: achabense <60953653+achabense@users.noreply.github.com>
@fsb4000
add some spaces
aec3166
@fsb4000
remove unneded if
0956d67
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Aug 29, 2023
@StephanTLavavej StephanTLavavej added the format C++20/23 format label Aug 29, 2023
@StephanTLavavej StephanTLavavej changed the title P2675R1 <format> generator converted from C++ to Python P2675R1 <format> generator converted from C++ to Python Aug 29, 2023
fsb4000 and others added 3 commits September 21, 2023 21:47
@fsb4000
rephrase some comments
7c75b61
@fsb4000
change the comments a bit
c8b9454
@achabense
> restore the location of LINE_REGEX
294f157 
> add comment for `fill_range`
> rename some variables
> type: bool~>int
> refine names for the two function; simplify comments
> better message
@achabense

This comment was marked as resolved.

Sign in to view
@StephanTLavavej
Copy link
Member

I've pushed a merge with main followed by:

  • Print the filename, timestamp, and C++ array.
  • Don't bother carefully wrapping; we need to clang-format anyways.
  • Use join to avoid a trailing comma interfering with clang-format.
  • Use a template string to make the C++ output clearer, like the other generators.
  • Format with Prettier.
  • Regenerate, capturing the filename and timestamp.
  • Cite the Standardese.

Because this table is changing over time, it's important to capture the filename/timestamp (with version info) so we can easily see when the table was last regenerated. The other changes allow the output to be copy-pasted into C++ and then clang-formatted, which is how the other generators behave too.

@CaseyCarter

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@strega-nil-ms
Copy link
Contributor

@StephanTLavavej, I've pushed changes (to change a comment explanation) after you approved.

@strega-nil-ms strega-nil-ms removed their assignment Oct 5, 2023
@StephanTLavavej StephanTLavavej self-assigned this Oct 6, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d61f7e0 into microsoft:main Oct 6, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

📖 ⚡ 🐍

@fsb4000 fsb4000 deleted the fix3908 branch October 7, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achabense achabense achabense left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@barcharcraz barcharcraz Awaiting requested review from barcharcraz

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved format C++20/23 format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert P2675R1 <format> generator from C++ to Python
6 participants
@fsb4000 @achabense @StephanTLavavej @CaseyCarter @strega-nil-ms @barcharcraz