Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<istream>, <ostream>: Deprecate pre-Standard ipfx, isfx, opfx, and osfx functions #4006

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

I found that these functions were present in some early prehistoric working drafts but removed before C++98 (see WG21-N0794 for rationale). I think it's helpful to say sentry classes should be used instead.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner September 3, 2023 16:20
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
frederick-vs-ja and others added 2 commits September 4, 2023 07:11
Co-authored-by: Jakub Mazurkiewicz <mazkuba3@gmail.com>
@StephanTLavavej StephanTLavavej self-assigned this Sep 5, 2023
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Sep 5, 2023
@StephanTLavavej StephanTLavavej removed their assignment Sep 7, 2023
@StephanTLavavej StephanTLavavej self-assigned this Sep 13, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9858519 into microsoft:main Sep 14, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for deprecating these pre-Cambrian functions! ☠️ 🦴 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants