make extern "C"
functions explicitly noexcept
#4106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions declared
extern "C"
are implicitlynoexcept(true)
when compiling with/EHc
, and implicitlynoexcept(false)
when compiling without. To ensure consistency regardless of the compiler's command line options, allextern "C"
functions should have explicit noexcept-specifiers.This change excludes (with explanatory comment) the redeclarations of
locale.h
functions inxlocinfo
to avoid clashing with the primary declarations in the UCRT.Drive-by:
mutex.cpp
, indicate that_Thrd_abort
is exported for ABI only; there are no callers outside this file.winapisupp.cpp
, the dynamic initializerinitialize_pointers
never throws exceptions and should therefore benoexcept
.vector_algorithms.cpp
, the APIs arenoexcept
so the helpers must be as well. Add annotations to make that contractual obligation explicit.