-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement formatter<vector<bool>::reference>
#4133
Merged
StephanTLavavej
merged 14 commits into
microsoft:main
from
frederick-vs-ja:formatter-vector-bool-reference
Nov 29, 2023
Merged
Implement formatter<vector<bool>::reference>
#4133
StephanTLavavej
merged 14 commits into
microsoft:main
from
frederick-vs-ja:formatter-vector-bool-reference
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Casey Carter <cacarter@microsoft.com>
StephanTLavavej
added
ranges
C++20/23 ranges
format
C++20/23 format
cxx23
C++23 feature
labels
Oct 30, 2023
tests/std/tests/P2286R8_text_formatting_vector_bool_reference/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_vector_bool_reference/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_vector_bool_reference/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_formattable/test.compile.pass.cpp
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Oct 31, 2023
tests/std/tests/P2286R8_text_formatting_vector_bool_reference/test.cpp
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
barcharcraz
reviewed
Nov 16, 2023
barcharcraz
approved these changes
Nov 16, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Jakub Mazurkiewicz <mazkuba3@gmail.com>
…_cpp_lib_concepts`.
…h_MEOW` back to `<format>`.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Nov 18, 2023
I pushed a conflict-free merge with
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for formatting part of everyone's favorite data structure! 😹 👻 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2919.
This PR contains 3 parts:
formattable
,range_format
, andformat_kind
#4116.<format>
needed for the definition ofstd::formatter
(but not its critical member functions) to a new internal header<__msvc_formatter.hpp>
.<vector>
, which is one of the most frequently used headers of STL, shouldn't include the whole<format>
.parse
andformat
functions are only required to be usable ifbasic_format_parse_context
andbasic_format_context
are available respectively, which is only guaranteed by including<format>
. So, I think it's safe to separate their definitions into<format>
.<thread>
is reduced as only_UIntegral_to_buff
is necessary.<stacktrace>
is currently unchanged because it contains non-templateparse
member function of a full specialization. Perhaps we can optimize it later.formatter<vector<bool, Alloc>::reference>
and test coverage for it.MSVC-internal changes are needed for the new header
<__msvc_formatter.hpp>
.