Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups: Use _STDEXT_BEGIN and _STDEXT_END #4145

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

StephanTLavavej
Copy link
Member

Select "Hide whitespace" to see how simple this change is.

We usually use our namespace macros when defining stdext machinery:

STL/stl/inc/iterator

Lines 1468 to 1470 in f392449

_STDEXT_BEGIN
template <class _Ptr>
class _DEPRECATE_STDEXT_ARR_ITERS checked_array_iterator { // wrap a pointer with checking

This PR fixes the one inconsistency in our headers. (Right now, there's no difference between the macros and directly mentioning the namespace, but in the future the macros might be trickier.)

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Nov 3, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner November 3, 2023 20:46
@StephanTLavavej StephanTLavavej self-assigned this Nov 6, 2023
@StephanTLavavej
Copy link
Member Author

I am a greedy kitty who's speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit f89524b into microsoft:main Nov 7, 2023
37 checks passed
@StephanTLavavej StephanTLavavej deleted the cleanup-stdext branch November 7, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants