Various cleanups: Enable more clang-format #4192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format has significantly improved its handling of concepts, so this PR removes over a hundred suppressions (from 295 down to 173).
In general, we should suppress clang-format only when it would do something egregious, or when there's a significant advantage to manual formatting (e.g. custom alignment of a table, or staying similar to upstream code). I looked at each of these suppression removals, and I believe that they're all neutral or an improvement. (I refrained from removing suppressions where clang-format would damage whitespace around
&&
. I also refrained from removals that would impact a lot of code, even if I thought the impact was positive; those are candidates for future cleanups.)I've structured this into a series of commits for easier review, listed below. There are no behavioral changes or other drive-by cleanups, and only a couple of manual changes to comments. (In this PR, I've refrained from adding empty comments to partially control formatting.)