Implement P2905R2 Runtime Format Strings #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Make `make_(w)format_args` only take lvalue references)
frederick-vs-ja
force-pushed
the
p2905r2
branch
from
afcc7e3
to
cb0d2da
Compare
StephanTLavavej
added
cxx20
StephanTLavavej
requested changes
Nov 15, 2023
barcharcraz
approved these changes
Dec 16, 2023
tests/std/tests/P0355R7_calendars_and_time_zones_formatting/test.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
+303
to
+304
| static_assert(CanMakeFormatArgs<Context, const int, const long long, const double, const char_type, | ||
| char_type* const, const char_type* const, const basic_string<char_type>, const basic_string_view<char_type>>); |
There was a problem hiding this comment.
No change requested: The fact that const rvalues are accepted indicates a design problem with the paper.
StephanTLavavej
approved these changes
Dec 16, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for completing C++20 again! ✅ 😹 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4184.
(Note that there'll be a trivial merge conflict with #4189.)Fixed myself.