Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<xlocnum>: Drop ios_base::showpoint flag when printing non-finite values #4212

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4210.

This PR is a workaround for DevCom-10519861 and may be affects redist because it modifies dll-exported functions.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner November 19, 2023 17:09
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Nov 19, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 19, 2023
@StephanTLavavej
Copy link
Member

Thanks! I pushed changes to fix the test and some minor nitpicks. I think this needs only one maintainer approval.

This affects separately compiled code but we don't need to wait for a redist update because it's not making coordinated changes between the headers and DLL. (Also 17.10 will be unlocked at some point.) Thanks for thinking about that, it's easy to forget.

@StephanTLavavej StephanTLavavej removed their assignment Nov 28, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 29, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5220c9c into microsoft:main Nov 29, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Infinite thanks for this fix! 🐞 🛠️ 😻

@frederick-vs-ja frederick-vs-ja deleted the inf-nan-no-point branch November 29, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<ostream>: With setprecision(0) showpoint fixed, a bogus '.' is emitted for infinity and NaN
2 participants