<sstream>: Pass the correct size type to _Allocate_at_least_helper
#4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang: sstream(263,39): error: no matching function for call to '_Allocate_at_least_helper' MSVC: sstream(263): error C2664: 'wchar_t *std::_Allocate_at_least_helper<test_allocator<wchar_t>>(_Alloc &,unsigned int &)': cannot convert argument 2 from 'size_t' to 'unsigned int &' Elsewhere we're already using `_Mysize_type`.
CaseyCarter
approved these changes
Nov 28, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on an llvm-project update, and it has an allocator with a custom size type that found this bug. In this PR, I'm not bothering to add any test coverage since llvm-project will provide so much.
Clang error:
MSVC error:
This code was using
size_tsince the beginning of history, we just missed the type mismatch in #3712 / #3864.Elsewhere we're already using
_Mysize_type.