Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Retail MSBuild Targets #4225

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Use Retail MSBuild Targets #4225

merged 1 commit into from
Dec 1, 2023

Conversation

CaseyCarter
Copy link
Member

This is the STL-specific part of internal MSVC-PR-510075.

@CaseyCarter
Use Retail MSBuild Targets
20709e5 
This is the STL-specific part of internal MSVC-PR-510075.
@CaseyCarter CaseyCarter added the build Related to the build system label Dec 1, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner December 1, 2023 21:08
@StephanTLavavej
Copy link
Member

Thanks! Double-checked that this is a binary-identical port, and re-reviewed the changes themselves.

I'll go update the Hack These Files checklist because the internal copy_crt_early.nativeproj has been renamed to copy_crt_early.vcxproj.

@CaseyCarter
Copy link
Member Author

I'll go update the Hack These Files checklist because the internal copy_crt_early.nativeproj has been renamed to copy_crt_early.vcxproj.

Good catch!

@StephanTLavavej StephanTLavavej merged commit 0403d19 into microsoft:main Dec 1, 2023
37 checks passed
@StephanTLavavej
Copy link
Member

🪞 🏗️ 🏛️

@CaseyCarter CaseyCarter deleted the port-build-changes branch August 20, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
build Related to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaseyCarter @StephanTLavavej