<sstream>: Don't swap basic_stringbufs in move assignment and allocator-extended construction
#4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and allocator-extended move construction.
This comment was marked as resolved.
This comment was marked as resolved.
frederick-vs-ja
commented
Dec 6, 2023
This comment was marked as resolved.
This comment was marked as resolved.
frederick-vs-ja
commented
Dec 7, 2023
StephanTLavavej
approved these changes
Jan 24, 2024
|
Thanks! 😻 I pushed a couple of bugfixes and I think this is ready to go. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this libcxx failure! 🎉 😻 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4232.
Notes:
_Copy_into_self_and_tidyfunction actually copies the buffer, which is needed when both allocators are not equal._Assign_rvis sometimes replaced with_Assign_rv_no_alias, which should avoid redundant address comparison.