ADL-proof implementation of [alg.modifying.operations] #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also add `_Is_trivially_ranges_swappable(_v)` to handle triviality - also add workaround for DevCom-10456445
tests/std/tests/P2538R1_adl_proof_std_projected/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jan 13, 2024
|
Thanks! I pushed a conflict-free merge with |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🛡️ 🎉 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4004, towards #140 and #1596.
Fixes #4043 by
::-qualifying all remaining__std_meowvectorizing functions (some are_STD-qualified in #4146).Also adds
_Is_trivially_ranges_swappable(_v)to handle triviality of swapping byranges::swap(which gets rid of ADL for pointers and pointers-to-members), along with workaround for DevCom-10456445.