Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a /clr workaround in test code #4340

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

StephanTLavavej
Copy link
Member

@Codiferous's MSVC-PR-522996 fixed VSO-1078742 DevCom-939490 "Calling a pointer to member function at constexpr time in /clr triggers internal compiler error" reported on 2020-03-04, so we can finally remove this workaround. As this is /clr, we can do so immediately, no need to wait for a toolset update. I've verified this internally.

…member function at constexpr time in /clr triggers internal compiler error".
@StephanTLavavej StephanTLavavej added the test Related to test code label Jan 24, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner January 24, 2024 03:28
@StephanTLavavej StephanTLavavej self-assigned this Jan 24, 2024
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit fef3c3d into microsoft:main Jan 25, 2024
37 checks passed
@StephanTLavavej StephanTLavavej deleted the i-can-see-clrly-now branch January 25, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants