Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to the Update Status Chart action #4365

Conversation

StephanTLavavej
Copy link
Member

Followup to #4223 where I said:

.github/workflows/update-status-chart.yml mentions github.token for the GraphQL API, but all it needs is public read-only access, so I don't think that it'll need to be changed.

Wrong! It autonomously commits changes:

- name: Commit Changes
run: |
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
git add src/daily_table.ts src/monthly_table.ts built/status_chart.mjs
git diff-index --quiet HEAD || git commit -m "Automated update."
git push origin gh-pages

So the workflow runs started failing with:

remote: Permission to microsoft/STL.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/microsoft/STL/': The requested URL returned error: 403
Error: Process completed with exit code 128.

I've verified in my fork that granting the contents: write permission is sufficient - we don't need to grant issues: read and pull-requests: read.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Feb 3, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 3, 2024 08:49
@StephanTLavavej StephanTLavavej self-assigned this Feb 5, 2024
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d9026de into microsoft:main Feb 6, 2024
37 checks passed
@StephanTLavavej StephanTLavavej deleted the i-am-now-authorized-to-be-loyal-as-a-puppy branch February 6, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants