ADL-proof implementation of remaining sorting-related algorithms #4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly conflicts with microsoft#4362.
- std/algorithms/robust_against_adl.compile.pass.cpp
frederick-vs-ja
changed the title
frederick-vs-ja
commented
Feb 4, 2024
…ow the `adjacent_find` pattern.
tests/std/tests/P2538R1_adl_proof_std_projected/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_001596_adl_proof_algorithms/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2538R1_adl_proof_std_projected/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2538R1_adl_proof_std_projected/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2538R1_adl_proof_std_projected/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Feb 5, 2024
|
Thanks! 😸 I pushed changes that I'm 98% sure about, please double-check. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
I've pushed a merge with |
StephanTLavavej
approved these changes
Feb 6, 2024
📈 🛡️ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #4004. Towards #140 and #1596.
Partially unblocks one libcxx test (the test still fails with MSVC due to DevCom-10456523):
std/algorithms/robust_against_adl.compile.pass.cpp@StephanTLavavej changed #4362 to avoid conflicting with this PR.