Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules workaround for views::pairwise_transform #4420

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

StephanTLavavej
Copy link
Member

Fixes #4404 by working around VSO-1975579 "Standard Library Modules: fatal error C1116: unrecoverable error importing module 'std'. Specialization of 'std::invoke_result_t' with arguments '_Fn, _Ty...'".

I don't trust the behavior of pack expansions here until @cdacamar fixes the compiler, so I've chosen to use a classical countdown for the workaround.

I checked our other usage of _Repeat_type and it didn't appear to be affected, presumably because it doesn't involve invoke_result_t.

@StephanTLavavej StephanTLavavej added bug Something isn't working modules C++23 modules, C++20 header units labels Feb 23, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 23, 2024 00:14
@StephanTLavavej StephanTLavavej self-assigned this Feb 23, 2024
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 517b783 into microsoft:main Feb 27, 2024
37 checks passed
@StephanTLavavej StephanTLavavej deleted the pearwise-transform branch February 27, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modules C++23 modules, C++20 header units
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

unrecoverable error importing module 'std' with std::ranges::views::pairwise_transform
2 participants