Expand old test coverage #4443
Merged
Expand old test coverage #4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MFs/PMDs. FDIS citations were so old, they escaped our scans for outdated WPs. We don't need to quote `INVOKE`'s Standardese at length, we just need to summarize it. It used to be really confusing, now it's easy mode. A couple of things have changed: derived values are now covered by the Standardese, and `reference_wrapper` support was added. This is tested elsewhere, e.g. in `Dev11_0535636_functional_overhaul`, but we can easily add comprehensive test coverage here. I chose `f1x` and `g1x` to avoid renumbering everything.
These typedefs were deprecated in C++17 and removed in C++20, so I'm citing N4659, the C++17 WP. We were also missing test coverage for when `mem_fn` provides only `result_type`. Even though this is deprecated/removed, we may as well be comprehensive.
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::functionPMFs/PMDs.INVOKE's Standardese at length, we just need to summarize it. It used to be really confusing, now it's easy mode.reference_wrappersupport was added. This is tested elsewhere, e.g. inDev11_0535636_functional_overhaul, but we can easily add comprehensive test coverage here.f1xandg1xto avoid renumbering everything.mem_fntypedefs.mem_fnprovides onlyresult_type. Even though this is deprecated/removed, we may as well be comprehensive.P0088R3_variant: Activate EDG test coverage.benchmarks/inc, include<cstdint>and qualifystd::.