Delete <cvt/meow>
#4458
Merged
Delete <cvt/meow>
#4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a tombstone for STL4044.
…0000_instantiate_cvt` (4 files, 7,866 bytes).
…00000_instantiate_cvt`.
…cets. There are no replacements for `stdext::cvt::codecvt_cp1251` and `stdext::cvt::codecvt_sjis`, but we can replace `stdext::cvt::codecvt_utf8_utf16` with the deprecated `std::codecvt_utf8_utf16`. This was the last use of `_SILENCE_STDEXT_CVT_DEPRECATION_WARNING`.
CaseyCarter
approved these changes
Mar 13, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282.
<cvt/meow>was deprecated by #3924 in VS 2022 17.8, so we'll have shipped two long-term-support releases (17.8 and 17.10) with that deprecation. @MahmoudGSaleh has confirmed that we can go ahead and remove these headers in 17.11. These headers were never documented.In VS, this will delete 78 files, 4.8 MB, which is the major benefit that users will experience. For us, it reduces our test costs and maintenance surface area.
stl/inc/cvt(78 files, 5,061,936 bytes).stl/CMakeLists.txt: Drop all${CMAKE_CURRENT_LIST_DIR}/inc/cvt/lines.yvals_core.h:_DEPRECATE_STDEXT_CVTis now unused; replace it with a tombstone for STL4044.tests/tr1/tests/cvt(76 files, 32,051 bytes).tests/tr1/include/cvt_xtest.h(1 file, 4,990 bytes).tests/tr1/test.lst: Drop alltests\cvt\lines.tests/std/tests: DeleteDev11_0453373_codecvt_compilesandVSO_0000000_instantiate_cvt(4 files, 7,866 bytes).tests/std/test.lst: DropDev11_0453373_codecvt_compilesandVSO_0000000_instantiate_cvt.P0218R1_filesystem: Drop/replace test coverage usingstdext::cvtfacets.stdext::cvt::codecvt_cp1251andstdext::cvt::codecvt_sjis.stdext::cvt::codecvt_utf8_utf16with the deprecatedstd::codecvt_utf8_utf16._SILENCE_STDEXT_CVT_DEPRECATION_WARNING.cvtsubdirectory from the build and setup authoring.