<format>: Conditionally emit special diagnostic message for lack of const
#4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also emit `static_assert` error messages for `basic_format_arg::handle`.
StephanTLavavej
added
enhancement
frederick-vs-ja
commented
Mar 11, 2024
| @@ -707,15 +715,23 @@ public: | |||
| using _Td = remove_const_t<_Ty>; | |||
| // doesn't drop const-qualifier per an unnumbered LWG issue | |||
| using _Tq = conditional_t<_Formattable_with<const _Ty, _Context>, const _Ty, _Ty>; | |||
| if constexpr (_Formattable_with_non_const<_Tq, _Context>) { | |||
There was a problem hiding this comment.
This ctor is exposition-only per [format.arg]/10 but is public in MSVC STL...
Perhaps we should consider making it private (in another PR, together with non-Standard public ctors of basic_format_context).
StephanTLavavej
approved these changes
Mar 13, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
static_assert(true, "Thanks! 🎉😸☑️"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4202.
Also adds
static_assertmessages in the constructor body ofbasic_format_arg::handle, and moves thestatic_asserts into the lambda body.Currently, Clang emits 2
static_assertfailures for such an error, one inmake_(w)format_args, one in thehandlector. Because lack offormatterspecialization orconstonformatcan triggerstatic_assertfailure in the constructor body ofbasic_format_arg::handlenow.This PR slightly worsens the error messages for Clang (2 similar
static_assertmessages will be emitted). However, it seems that cleaner error messages can be achieved by conditional compilation (skippingstatic_asserts inmake_(w)format_argsfor Clang).