Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary flag to xiosbase class to correct place #4493

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

ecrinyildiz
Copy link
Contributor

No description provided.

@ecrinyildiz ecrinyildiz requested a review from a team as a code owner March 20, 2024 13:55
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 20, 2024
@StephanTLavavej
Copy link
Member

Sure, this is reasonable. We can freely reorder them (unlike virtual function declarations, for example), and while we aren't following the Standard's order, following bit flag order makes sense.

@StephanTLavavej StephanTLavavej self-assigned this Mar 21, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@ecrinyildiz
Copy link
Contributor Author

ecrinyildiz commented Mar 21, 2024

I am still using this library. if i can catch something to change to be more clearance/readable, I will let you know.
And also, I didnt mention any detail with PR, thanks for understanding. this is my first time contribution to very big team.

@StephanTLavavej StephanTLavavej merged commit 8e2d724 into microsoft:main Mar 21, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks again and congratulations on your first microsoft/STL commit! 😸 🎉 🚀

This change is expected to ship in VS 2022 17.11 Preview 1.

For the future - yes, detailed PR descriptions are appreciated, although in this case I could immediately see your intent. 😹 Also, while merging I noticed that your commit was made with a different email address than your GitHub account, so it showed up as a "co-authored-by" commit. You can teach GitHub to recognize alternate email addresses (as I have done, since I regularly make commits tagged with both my work and home email addresses, depending on which computer I'm working from). If you go to your Settings > Emails, you can add alternate email addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants