Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3950 std::basic_string_view comparison operators are overspecified #4510

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Implement LWG-3950 std::basic_string_view comparison operators are overspecified #4510

merged 2 commits into from
Mar 28, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4500.

Tests whether std::type_identity_t is exactly used, see #4249.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 23, 2024 15:41
@StephanTLavavej StephanTLavavej changed the title Implement LWG-3950 Implement LWG-3950 std::basic_string_view comparison operators are overspecified Mar 23, 2024
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue spaceship C++20 operator <=> labels Mar 23, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 23, 2024
@StephanTLavavej StephanTLavavej removed their assignment Mar 26, 2024
@StephanTLavavej
Copy link
Member

Thanks, this is so much simpler, and your test coverage is excellent! 😻

The diff looks complicated but I verified that it's a very clean transformation that properly handles _EXPORT_STD and doesn't disrupt pre-C++20 code at all.

@StephanTLavavej StephanTLavavej self-assigned this Mar 27, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit e0a75b3 into microsoft:main Mar 28, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

🧵 🛰️ 🧶

@frederick-vs-ja frederick-vs-ja deleted the lwg-3950 branch March 28, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue spaceship C++20 operator <=>
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3950 std::basic_string_view comparison operators are overspecified
2 participants
@frederick-vs-ja @StephanTLavavej