Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-4012 common_view::begin/end are missing the simple-view check #4529

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Implement LWG-4012 common_view::begin/end are missing the simple-view check #4529

merged 1 commit into from
Mar 28, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4502.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 24, 2024 16:25
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue ranges C++20/23 ranges labels Mar 25, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 25, 2024
@StephanTLavavej StephanTLavavej removed their assignment Mar 26, 2024
@StephanTLavavej
Copy link
Member

Thanks! 😻 I really appreciate the test coverage here - it would not have been obvious to me how to test this.

@StephanTLavavej StephanTLavavej self-assigned this Mar 27, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 370f9a9 into microsoft:main Mar 28, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for the uncommonly fast implementation of this LWG issue resolution! 😹 🤪 🚀

@frederick-vs-ja frederick-vs-ja deleted the lwg-4012 branch March 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-4012 common_view::begin/end are missing the simple-view check
2 participants
@frederick-vs-ja @StephanTLavavej