-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectorize lexicographical_compare
!
#4552
Merged
StephanTLavavej
merged 14 commits into
microsoft:main
from
AlexGuteniev:not_another_vector_algorithms_cpp_change
Apr 12, 2024
Merged
Vectorize lexicographical_compare
!
#4552
StephanTLavavej
merged 14 commits into
microsoft:main
from
AlexGuteniev:not_another_vector_algorithms_cpp_change
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
changed the title
Vectorize lexicographical_compare!
Vectorize Apr 3, 2024
lexicographical_compare
!
StephanTLavavej
requested changes
Apr 7, 2024
AlexGuteniev
commented
Apr 8, 2024
tests/std/tests/GH_000431_lex_compare_memcmp_classify/test.compile.pass.cpp
Show resolved
Hide resolved
AlexGuteniev
commented
Apr 9, 2024
…thub.com/AlexGuteniev/STL into not_another_vector_algorithms_cpp_change
…algorithms_cpp_change # Conflicts: # stl/inc/xutility
tests/std/tests/GH_000431_lex_compare_memcmp_classify/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_000431_lex_compare_memcmp_classify/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Apr 12, 2024
Thanks - this is so much easier to follow! 😻 🧠 |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for vectorizing one of the STL's most important algorithms! 😻 🚀 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3998
Using existing
mismatch
vectorization and existing classifiers.Benchmark
Before:
After: