Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vectorize replace 🎭 #4554

Merged
merged 18 commits into from
Apr 9, 2024
Merged

vectorize replace 🎭 #4554

merged 18 commits into from
Apr 9, 2024

Conversation

AlexGuteniev
Copy link
Contributor

AVX2 masks only

Before

---------------------------------------------------------------
Benchmark                     Time             CPU   Iterations
---------------------------------------------------------------
r<std::uint32_t>           2005 ns         1086 ns      1280000
r<std::uint64_t>           2107 ns         1247 ns       814545

After

---------------------------------------------------------------
Benchmark                     Time             CPU   Iterations
---------------------------------------------------------------
r<std::uint32_t>            173 ns         73.8 ns     19063830
r<std::uint64_t>            441 ns          178 ns      7466667

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner April 2, 2024 11:48
@StephanTLavavej StephanTLavavej added the performance Must go faster label Apr 2, 2024
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@AlexGuteniev

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this Apr 2, 2024
@AlexGuteniev AlexGuteniev changed the title vectorize replace vectorize replace 🎭 Apr 2, 2024
StephanTLavavej
StephanTLavavej reviewed Apr 4, 2024
View reviewed changes
stl/src/vector_algorithms.cpp Outdated Show resolved Hide resolved
stl/src/vector_algorithms.cpp Show resolved Hide resolved
tests/std/tests/VSO_0000000_vector_algorithms/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/VSO_0000000_vector_algorithms/test.cpp Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Apr 4, 2024
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 8, 2024
Merged
@StephanTLavavej StephanTLavavej self-assigned this Apr 8, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit bed2673 into microsoft:main Apr 9, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for massively improving performance here! 🚀 😸 🐈

@AlexGuteniev AlexGuteniev deleted the heroes_wear_masks branch April 10, 2024 03:26
@AlexGuteniev AlexGuteniev mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
performance Must go faster
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexGuteniev @StephanTLavavej