Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: un-skip a few libc++ tests that were believed to have timing assumptions #4698

Merged
merged 1 commit into from
May 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions tests/libcxx/expected_results.txt
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ std/utilities/memory/default.allocator/allocator.ctor.pass.cpp FAIL
# LWG-3197 "std::prev should not require BidirectionalIterator" (New)
std/iterators/iterator.primitives/iterator.operations/prev.pass.cpp FAIL

# Itanium ABI assumptions that current_exception and rethrow_exception don't copy the exception object.
# The SKIPPED tests contain `XFAIL: msvc`, which is not well understood by the test harness.
std/language.support/support.exception/except.nested/rethrow_if_nested.pass.cpp SKIPPED
std/language.support/support.exception/propagation/current_exception.pass.cpp SKIPPED

# Testing nonstandard behavior
std/utilities/template.bitset/bitset.cons/string_ctor.pass.cpp FAIL

Expand Down Expand Up @@ -597,7 +592,6 @@ std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move_convert.
std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move.pass.cpp FAIL

# Not analyzed, likely bogus tests. Appears to be timing assumptions.
std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_notify_all.pass.cpp SKIPPED
std/thread/futures/futures.async/async.pass.cpp SKIPPED
std/thread/futures/futures.shared_future/get.pass.cpp SKIPPED
std/thread/futures/futures.shared_future/wait.pass.cpp SKIPPED
Expand All @@ -618,8 +612,6 @@ std/thread/thread.condition/thread.condition.condvarany/wait_for_pred.pass.cpp S
std/thread/thread.condition/thread.condition.condvarany/wait_for.pass.cpp SKIPPED
std/thread/thread.condition/thread.condition.condvarany/wait_until_pred.pass.cpp SKIPPED
std/thread/thread.condition/thread.condition.condvarany/wait_until.pass.cpp SKIPPED
std/thread/thread.mutex/thread.lock/thread.lock.guard/adopt_lock.pass.cpp SKIPPED
std/thread/thread.mutex/thread.lock/thread.lock.guard/mutex.pass.cpp SKIPPED
std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_duration.pass.cpp SKIPPED
std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_time_point.pass.cpp SKIPPED
std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_try_to_lock.pass.cpp SKIPPED
Expand Down Expand Up @@ -654,8 +646,6 @@ std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements
std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_for.pass.cpp SKIPPED
std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_until.pass.cpp SKIPPED
std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock.pass.cpp SKIPPED
std/thread/thread.threads/thread.thread.class/thread.thread.destr/dtor.pass.cpp SKIPPED
std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp SKIPPED
std/thread/thread.threads/thread.thread.this/sleep_until.pass.cpp SKIPPED

# Not analyzed, likely bogus tests. Various assertions, probably POSIX assumptions.
Expand Down Expand Up @@ -1357,6 +1347,10 @@ std/time/time.syn/formatter.weekday_last.pass.cpp:2 SKIPPED
std/time/time.syn/formatter.weekday.pass.cpp:0 SKIPPED
std/time/time.syn/formatter.weekday.pass.cpp:2 SKIPPED
std/time/time.syn/formatter.year_month_day.pass.cpp:2 SKIPPED
std/language.support/support.exception/except.nested/rethrow_if_nested.pass.cpp:0 SKIPPED
std/language.support/support.exception/except.nested/rethrow_if_nested.pass.cpp:2 SKIPPED
std/language.support/support.exception/propagation/current_exception.pass.cpp:0 SKIPPED
std/language.support/support.exception/propagation/current_exception.pass.cpp:2 SKIPPED


# *** MSVC-INTERNAL TEST HARNESS ISSUES (note: configuration :9 restricts these skips to be MSVC-internal) ***
Expand Down