Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _MSVC_STL_UPDATE to June 2024 in yvals_core.h #4708

Closed
wants to merge 2 commits into from

Conversation

Arup-Chauhan
Copy link
Contributor

@Arup-Chauhan Arup-Chauhan commented Jun 3, 2024

Fixes #4704

This pull request updates the _MSVC_STL_UPDATE macro value in yvals_core.h to the latest version. This change is intended to reflect the current state of the STL.

@Arup-Chauhan Arup-Chauhan requested a review from a team as a code owner June 3, 2024 08:36
@Arup-Chauhan
Copy link
Contributor Author

Hi, as per the requirements of the contributing to STL open source, I have made a PR request, please approve.

@jovibor
Copy link
Contributor

jovibor commented Jun 3, 2024

It intersects with already opened #4706.

@Arup-Chauhan
Copy link
Contributor Author

It intersects with already opened #4706.

Hi I wanted to follow the "good-first-issue" methodology as mentioned by Stephan and contribute to STL open source and hence raised this PR.

Please guide me is there any other alternative, to avoid this intersection?

@jovibor
Copy link
Contributor

jovibor commented Jun 3, 2024

I mean your PR is a duplicate of the #4706 that was opened a bit earlier.

@Arup-Chauhan
Copy link
Contributor Author

I mean your PR is a duplicate of the #4706 that was opened a bit earlier.

Yes, I did notice it, what should be my next steps?

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jun 4, 2024
@StephanTLavavej
Copy link
Member

Thanks! We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. As #4706 was created earlier, but wasn't initially linked to the issue it resolves, I believe you both deserve credit. I'll merge the earlier-created PR, but credit you as a co-author. I'll post a comment here when that happens.

@Arup-Chauhan
Copy link
Contributor Author

Thanks! We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. As #4706 was created earlier, but wasn't initially linked to the issue it resolves, I believe you both deserve credit. I'll merge the earlier-created PR, but credit you as a co-author. I'll post a comment here when that happens.

Thank you @StephanTLavavej ! Looking forward for more contributions!

@StephanTLavavej
Copy link
Member

I've merged the earlier-created PR and credited you as a co-author for this identical change:

065a036

I'll also link your PR in the STL Changelog. Thanks again and congratulations on your first STL commit! 🎉 😸 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to June 2024
3 participants