Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2968R2 Make std::ignore A First-Class Object #4777

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

NeilGeorge1
Copy link
Contributor

@NeilGeorge1 NeilGeorge1 commented Jul 1, 2024

As requested moved class deinition of _Ignore and ignore to the utility header file
removed the /* strengthened */ comment from the operator=, and
added the // P2968R2 Make std::ignore A First-Class Object comment to <yvals_core.h>

Fixes #4756

@NeilGeorge1 NeilGeorge1 requested a review from a team as a code owner July 1, 2024 12:36
@NeilGeorge1
Copy link
Contributor Author

NeilGeorge1 commented Jul 1, 2024

@microsoft-github-policy-service agree company="NA"
@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="Microsoft"

stl/inc/tuple Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the cxx26 C++26 feature label Jul 1, 2024
stl/inc/utility Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Jul 2, 2024
@NeilGeorge1
Copy link
Contributor Author

Since all checks have passed will this pr be merged soon?

Copy link
Contributor

@AlexGuteniev AlexGuteniev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are pedantic regarding whitespace

stl/inc/tuple Outdated Show resolved Hide resolved
stl/inc/utility Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Show resolved Hide resolved
@StephanTLavavej

This comment was marked as resolved.

@NeilGeorge1

This comment was marked as resolved.

@AlexGuteniev

This comment was marked as resolved.

stl/inc/utility Outdated Show resolved Hide resolved
@NeilGeorge1

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej removed their assignment Jul 4, 2024
@StephanTLavavej
Copy link
Member

Perfect, thank you! 😻

We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, possibly this Friday or possibly next week due to the holiday. I'll post comments here as I prepare your PR for merging - no further action is required.

@StephanTLavavej StephanTLavavej changed the title P2968R2 Make std::ignore A First-Class Object #4756 P2968R2 Make std::ignore A First-Class Object Jul 4, 2024
@NeilGeorge1
Copy link
Contributor Author

Thanks for the update! Big thanks to all the reviewers for their feedback and help on this PR. I really appreciate it. Looking forward to the merge! 😃

@StephanTLavavej StephanTLavavej self-assigned this Jul 4, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej changed the title P2968R2 Make std::ignore A First-Class Object P2968R2 Make std::ignore A First-Class Object Jul 4, 2024
@StephanTLavavej StephanTLavavej merged commit 4406e0e into microsoft:main Jul 5, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for implementing this C++26 feature, and congratulations on your first microsoft/STL commit! 😻 ✅ 🚀

This will ship in VS 2022 17.12 Preview 1. After that, every programmer who uses std::ignore via <utility> will be using your change! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx26 C++26 feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

P2968R2 Make std::ignore A First-Class Object
5 participants