-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2968R2 Make std::ignore A First-Class Object #4777
Conversation
@microsoft-github-policy-service agree company="NA" |
Since all checks have passed will this pr be merged soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are pedantic regarding whitespace
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Perfect, thank you! 😻 We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, possibly this Friday or possibly next week due to the holiday. I'll post comments here as I prepare your PR for merging - no further action is required. |
Thanks for the update! Big thanks to all the reviewers for their feedback and help on this PR. I really appreciate it. Looking forward to the merge! 😃 |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for implementing this C++26 feature, and congratulations on your first microsoft/STL commit! 😻 ✅ 🚀 This will ship in VS 2022 17.12 Preview 1. After that, every programmer who uses |
As requested moved class deinition of _Ignore and ignore to the utility header file
removed the /* strengthened */ comment from the operator=, and
added the // P2968R2 Make std::ignore A First-Class Object comment to <yvals_core.h>
Fixes #4756