Remove std::ranges::view_interface
visualizer.
#4835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4830
Actually I tested it and I think
std::ranges::view_interface
natvis may be useless.My test code:
For
std::ranges::view_interface
withoutsize()
I usedistream_view
.For
std::ranges::view_interface
withsize()
I usedVectorView
from https://en.cppreference.com/w/cpp/ranges/view_interfaceI also called
size()
,front()
,empty()
,back()
,data()
because the compiler didn't generate these methods by default and Natvis showedunknown size
.My results:
As I can see Natvis never calls methods. It works great only for memory variables and intrinsics.
iota_view example:
And because
std::ranges::view_interface
is dependent from_Derived
, we can't create an intrinsic for its size.Am I correct and we always will receive "???" or "This expression has side effects and will not be evaluate"?