-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<chrono>
: Add comments for compiler bug workarounds
#4920
<chrono>
: Add comments for compiler bug workarounds
#4920
Conversation
I guess that was also a workaround for EDG. We'll need to reduce a repro to send to the Edge team and conditionally (or unconditionally) restore the workaround with a transition comment. |
Reduced to: struct S {
int x, y;
};
void f(void* ptr) {
S(13, 42); // Ok
new S(13, 42); // error: no instance of constructor "S::S" matches
} Which I filed as VSO-2228186 and added to #1621. |
This reverts commit 27f4679.
<chrono>
: Simplify tzdb_list
a bit around emplace_front
<chrono>
: Remove testing-only internal function template tzdb_list::_Emplace_front
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Instead of guarding this test coverage for |
<chrono>
: Remove testing-only internal function template tzdb_list::_Emplace_front
<chrono>
: Add comments for compiler bug workarounds
Thanks for helping us find and report so many compiler bugs! 🐞 ⏱️ 😹 |
The internal function template
tzdb_list::_Emplace_front
(initially added in #1671) only exists for testing. I found that it's possibly to completely hack in the test codes, so this PR removes it.After Clang 16 got WG21-P0960R3 implemented, it should be no longer necessary to construct a
tzdb
before callingemplace_front
. It seems more efficient to directly construct thetzdb
element withinemplace_front
. But there's some bug in EDG so perhaps it's better to give up the change.